Failure with compound requests and aio enabled
jra at samba.org
Fri Sep 22 02:36:44 UTC 2017
On Thu, Sep 21, 2017 at 06:02:52PM -0700, Jeremy Allison via samba-technical wrote:
> On Thu, Sep 21, 2017 at 05:49:24PM -0700, Christof Schmitt wrote:
> > On Thu, Sep 21, 2017 at 05:34:44PM -0700, Jeremy Allison wrote:
> > > On Thu, Sep 21, 2017 at 05:31:16PM -0700, Christof Schmitt wrote:
> > > >
> > > > Nevermind, i found a way. schedule_smb2_sendfile_read() already checks
> > > > smb2req->in.vector_count to determine whether the request is part of a
> > > > compound. I will reuse this check. Updated patch will follow.
> > >
> > > Oh that's *great* - thanks ! Not adding that bool
> > > preserves the VFS ABI. I thought there must be a
> > > way to detect this...
> > See attached patches. Should i open a bugzilla for a backport?
> Thanks - I'll review. There is already a bug report I think
> I closed :-). You could always reopen that one :-).
Couldn't find the original so I opened:
Reviewed-by: Jeremy Allison <jra at samba.org>
Pushed - thanks !
More information about the samba-technical