[PATCHES] Generate shorter name for extra python files

Lukas Slebodnik lslebodn at redhat.com
Thu Sep 21 22:07:34 UTC 2017


On (21/09/17 22:38), Lukas Slebodnik via samba-technical wrote:
>On (21/09/17 09:27), Andrew Bartlett wrote:
>>Thanks for sending in the new patch set.
>>
>>My concern is that by having the same python ABI file in samba, it will
>>break with:
>>
>>#if PY_MAJOR_VERSION < 3
>>
>>static void py_cobject_talloc_free(void *ptr)
>>{
>>        talloc_free(ptr);
>>}
>>
>>_PUBLIC_ PyObject *pytalloc_CObject_FromTallocPtr(void *ptr)
>>{
>>        if (ptr == NULL) {
>>                Py_RETURN_NONE;
>>        }
>>        return PyCObject_FromVoidPtr(ptr, py_cobject_talloc_free);
>>}
>>
>>#endif
>>
>>from pytalloc-util.c
>>
>>If you build with python 2 that will not be included in the ABI, and if
>>you build with python3 it will.
>>
>>That is why we need distinct ABI files for python 2 and python 3.
>>
>I do not have a problem with distinct ABI files for python 2 and python 3.
>Initial version of patches didn't contain it. Files were merged
>per requests in previous mails. Or did I misunderstand something?
>
Actually,
I cannot see any problem with current patches and
pytalloc_CObject_FromTallocPtr

sh# objdump -T /usr/lib64/libpytalloc-util.so.2.1.10 | grep CObject
0000000000000000      DF *UND*  0000000000000000              PyCObject_FromVoidPtr
0000000000001820 g    DF .text  0000000000000024  PYTALLOC_UTIL_2.0.6 pytalloc_CObject_FromTallocPtr
sh# objdump -T /usr/lib64/libpytalloc-util-cp36m.so.2.1.10 | grep CObject
sh# echo $?
1

Andrew,
Could you provide me steps to reproduce your case?

LS



More information about the samba-technical mailing list