[PATCHES] Generate shorter name for extra python files

Andrew Bartlett abartlet at samba.org
Wed Sep 20 21:27:31 UTC 2017


Thanks for sending in the new patch set.

My concern is that by having the same python ABI file in samba, it will
break with:

#if PY_MAJOR_VERSION < 3

static void py_cobject_talloc_free(void *ptr)
{
        talloc_free(ptr);
}

_PUBLIC_ PyObject *pytalloc_CObject_FromTallocPtr(void *ptr)
{
        if (ptr == NULL) {
                Py_RETURN_NONE;
        }
        return PyCObject_FromVoidPtr(ptr, py_cobject_talloc_free);
}

#endif

from pytalloc-util.c

If you build with python 2 that will not be included in the ABI, and if
you build with python3 it will.

That is why we need distinct ABI files for python 2 and python 3.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list