[PATCH] Rework ctdb_killtcp using a tevent_req computation, plus supporting code

[Martin Schwenke]

On Mon, 18 Sep 2017 17:29:38 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Fri, Sep 15, 2017 at 12:43 PM, Martin Schwenke via samba-technical <
> samba-technical at lists.samba.org> wrote:
> 
> > This is a rewrite of CTDB's TCP connection killing tool.  It now uses a
> > tevent_req computation that is ready to be factored out and incorporated
> > into the upcoming connection tracking rewrite/modularisation.
> >
> > The patches series does these things:
> >
> > * Separate out ctdb-protocol-util from the ctdb-protocol subsystem
> >
> > * Add additional protocol utility code for parsing and printing
> >   addresses/sockets/connections
> >
> > * Add ctdb_connection_list, marshalling and supporting utilities
> >
> > * Clean up ctdb_killtcp
> >
> > * Rework ctdb_killtcp to use tevent_req computation
> >
> > The series contains one commit from Amitay that already has my review.
> >
> > With this upstream, my connection tracking branch will be smaller and
> > easier to review (soon!).  However, this work will need to go "on ice"
> > for a little while.  It uses a replicated database and needs to fit
> > into a changed design where services, including IP failover, are shut
> > down when a node is inactive (and databases are inaccessible).  This is
> > was planned but I forgot about it and tried to integrate the new
> > connection tracking subsystem anyway...  ;-)
> >
> > There are some other code clean-ups to come that can take advantage this
> > current patch-set.
> >
> > Please review and maybe push...
> >
> > peace & happiness,
> > martin
> >
> 
> Pushed to autobuild.

As discussed off-list...

This fell over in autobuild because I was initialising a union with
{ 0 } and the compiler there (rightly, I think) does not like that.
Instead, I've removed that initialisation and
have updated ctdb_sys_read_tcp_packet() (for all platforms) to
zero the src and dst addresses before use.

Pushed again...

peace & happiness,
martin