[PATCH] call setproctitle_init in samba daemon

[Gary Lockyer]

Andrew and I are happy with the changed patchset

Thanks
Gary.

On 18/09/17 11:41, Ralph Böhme wrote:
> On Thu, Sep 14, 2017 at 05:35:06AM +0000, Gary Lockyer via samba-technical wrote:
>> Address BUG: https://bugzilla.samba.org/show_bug.cgi?id=9816
>>
>> But more importantly displays meaningful output in ps.
> 
> generally looks good, two issue:
> 
> - spelling mistake, setptoctitle_init instead of setproctitle_init
>                         ^
> 
> - one hunk only changed the indentation of a function:
> 
>   @@ -355,8 +355,8 @@ static void atfork_child(void) {
>     main server.
>    */
>    static int binary_smbd_main(const char *binary_name,
>   -                               int argc,
>   -                               const char *argv[])
>   +                           int argc,
>   +                           const char *argv[])
>    {
>           bool opt_daemon = false;
>           bool opt_interactive = false;
>   
>   I guess this can be removed?
> 
> - the three args main() variant is not-portable afaict, we may want to use the
>   portable global environ pointer instead, cf the FIXUP commit in the attached
>   patchset
> 
> - one commit message had a few spelling mistakes also fixed in the attached
>   patchset
> 
> Cheerio!
> -slow
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170918/9f68aa50/signature.sig>