[PATCH] Port of samba.messaging to Python 3

[Lumir Balhar]

On 09/15/2017 05:58 AM, Andrew Bartlett wrote:
> On Thu, 2017-09-14 at 20:02 +1200, Andrew Bartlett wrote:
>> On Thu, 2017-09-14 at 09:50 +0200, Lumir Balhar via samba-technical
>> wrote:
>>> Hello.
>>>
>>> I've made another module - samba.messaging - Python 3 compatible. The
>>> messaging module already has good test suite so I just ported it as well.
>> I agree, it has a good testsuite.  It is lucky for you that you waited,
>> it was much less complete (or even functional!) just a few months ago.
>>
>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>
>> Collect a second team reviewer and I'm sure this can join our autobuild
>> queue!
> Sadly it failed with:
>
> [2149/4224] Compiling source4/lib/messaging/pymessaging.c
> ../source4/lib/messaging/pymessaging.c:496:2: error: missing braces
> around initializer [-Werror=missing-braces]
>    PyObject_HEAD_INIT(NULL) 0,
>    ^
> ../source4/lib/messaging/pymessaging.c:496:2: error: (near
> initialization for imessaging_Type.ob_base.ob_base) [-Werror=missing-
> braces]
> cc1: all warnings being treated as errors
> Waf: Leaving directory `/memdisk/abartlet/a/b521293/samba/bin'
> Build failed:  -> task failed (err #1):
>          {task: cc pymessaging.c -> pymessaging_9.o}
> make: *** [all] Error 1
>
> Andrew Bartlett
Hi.

I am sorry about that. I don't know how it is possible that my 
build/test went well.

Fix patch attached.

Have a nice day.
Lumír
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python-Fix-Python-3-compatibility-in-samba.messaging.patch
Type: text/x-patch
Size: 894 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170915/b52eadef/0003-python-Fix-Python-3-compatibility-in-samba.messaging.bin>