[PATCH] [Bug 13033] LDB open with LDB_FLG_RDONLY can cause the database to fail to open

[Andrew Bartlett]

On Fri, 2017-09-15 at 14:17 +1200, Douglas Bagnall wrote:
> This is weird, because the same comment seems to repeat for multiple
> cases but only seems to apply to LDB_FLG_RDONLY.

> This is weird, because the same comment seems to repeat for multiple
> cases but only seems to apply to LDB_FLG_RDONLY.

Indeed, it looks like cut & paste repetition to me ;-)

> I am also not sure why the tdb modifications in ldb_index.c don't need
> the `if (ltdb->read_only)` guard. Is it that you can't cause a reindex
> without an add or delete?

Correct, those should also be guarded.

I'm looking forward to sorting those out on Monday.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba