s3: Patch to smbclient to add a utimes command for setting the Windows times
Volker.Lendecke at SerNet.DE
Fri Sep 15 00:17:55 UTC 2017
On Thu, Sep 14, 2017 at 12:21:16PM -0700, Richard Sharpe via samba-technical wrote:
> > ENOPATCH :-).
> Sorry. Should be attached now.
Standard review reply from me: This has lines beyond 80 characters. We
have a snippet in README.Coding about that:
* Maximum Line Width is 80 Characters
The reason is not about people with low-res screens but rather sticking
to 80 columns prevents you from easily nesting more than one level of
if statements or other code blocks. Use source3/script/count_80_col.pl
to check your changes.
Can you make sure that you get the lines into that range?
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical