[PATCH] Fix implementation of CTDB control PROCESS_EXISTS (bug 13012)

Amitay Isaacs amitay at gmail.com
Tue Sep 12 06:00:35 UTC 2017


On Tue, Sep 12, 2017 at 3:30 PM, Martin Schwenke via samba-technical <
samba-technical at lists.samba.org> wrote:

> On Fri, 8 Sep 2017 21:51:16 +1000, Martin Schwenke via samba-technical
> <samba-technical at lists.samba.org> wrote:
>
> > On Fri, 8 Sep 2017 16:50:03 +1000, Martin Schwenke via samba-technical
> > <samba-technical at lists.samba.org> wrote:
> >
> > > On Thu, 7 Sep 2017 17:39:48 +1000, Amitay Isaacs via samba-technical
> > > <samba-technical at lists.samba.org> wrote:
> > >
> > > > CTDB daemon should check processes that are connected to the daemon
> as
> > > > clients (e.g. smbd) and not check any random processes on the system.
> > > >
> > > > Please review and push.
> > >
> > > Reviewed-by: Martin Schwenke <martin at meltin.net>
> >
> > ... and pushed.
>
> There's a little race in the test here.  The attached patch seems to
> fix it.
>
>
Thanks for identifying the race condition.

We also need a fix to test_wrap to correctly set up the PATH.

Attached patches include:
- Martin's fix with missing BUG tag and my reviewed-by.
- Fix to test_wrap.

Please review and push.

Amitay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ctdb.patch
Type: text/x-patch
Size: 2203 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170912/59d248ef/ctdb-0001.bin>


More information about the samba-technical mailing list