[PATCH] Fix coverity issue in ctdb
martin at meltin.net
Fri Sep 8 11:51:41 UTC 2017
On Fri, 8 Sep 2017 16:51:44 +1000, Martin Schwenke via samba-technical
<samba-technical at lists.samba.org> wrote:
> On Thu, 7 Sep 2017 11:43:49 +1000, Amitay Isaacs via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > On Wed, Sep 6, 2017 at 4:03 PM, Volker Lendecke <Volker.Lendecke at sernet.de>
> > wrote:
> > > On Wed, Sep 06, 2017 at 11:34:32AM +1000, Amitay Isaacs via
> > > samba-technical wrote:
> > >
> > > Are you sure that fixes 1414746? I don't fully understand the CID, but
> > > my impression is that the the overflow is not from assigning ssize_t
> > > to int.
> > >
> > >
> > You are correct. It's not the fix for actual CID. Actual CID is the
> > overflow of db_flags.
> > Here are the modified patches.
> > - first patch is fixing the overflow (int --> ssize_t)
> > - second patch should fix the CID
> Reviewed-by: Martin Schwenke <martin at meltin.net>
... and pushed.
peace & happiness,
More information about the samba-technical