[PATCH] smbd: add missing newline to debug message in daemon_status()

Andrew Bartlett abartlet at samba.org
Thu Sep 7 19:42:33 UTC 2017


If it really needs to see that string, perhaps a printf to stderror
might be better, but in the meantime:

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Thanks!

On Thu, 2017-09-07 at 11:05 -0700, Justin Maggard via samba-technical
wrote:
> Signed-off-by: Justin Maggard <jmaggard at netgear.com>
> ---
>  lib/util/become_daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/util/become_daemon.c b/lib/util/become_daemon.c
> index 22c1778d4a4..232eda69b64 100644
> --- a/lib/util/become_daemon.c
> +++ b/lib/util/become_daemon.c
> @@ -146,5 +146,5 @@ void daemon_status(const char *daemon, const char *msg)
>  #if defined(HAVE_LIBSYSTEMD_DAEMON) || defined(HAVE_LIBSYSTEMD)
>  	sd_notifyf(0, "\nSTATUS=%s: %s", daemon, msg);
>  #endif
> -	DBG_ERR("STATUS=daemon '%s' : %s", daemon, msg);
> +	DBG_ERR("STATUS=daemon '%s' : %s\n", daemon, msg);
>  }
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list