[PATCH] Use Intel AES instruction set if it exists - v4

Stefan Metzmacher metze at samba.org
Wed Sep 6 23:49:22 UTC 2017


Am 06.09.2017 um 22:07 schrieb Jeremy Allison:
> On Wed, Sep 06, 2017 at 12:10:17PM -0700, Jeremy Allison via samba-technical wrote:
>> On Wed, Sep 06, 2017 at 08:52:58PM +0200, Stefan Metzmacher wrote:
>>> Am 06.09.2017 um 18:15 schrieb Jeremy Allison:
>>>> On Wed, Sep 06, 2017 at 03:38:20PM +0200, Stefan Metzmacher wrote:
>>>>> Hi Jeremy,
>>>>>
>>>>> can you please check the indentation in various wscript files,
>>>>> they're python scripts and should not use tabs, 4 spaces.
>>>>>
>>>>> Also running "git show eb1f476657c" in a recent kernel checkout,
>>>>> gives a failure.
>>>>
>>>> That's a Samba hash, not a kernel one.
>>>
>>> No, that's the hash of the file content and I'd assume that doesn't
>>> change if we just copy the file.
>>
>> Ah, got it. We do need to change it to compile as a -fPIC library
>> for Samba.
>>
>>> Thanks!
>>
>> I've now got a patchset that starts from a pristine kernel
>> check-in with a known git refspec and shows what is modified
>> from there.
>>
>> Testing now.
> 
> Here it is. Please review. I'm hoping v4 will be the last one,
> fingers crossed !

What's the reason to take such an old version?

There were some fixes in the patchset up to
cce2ea8d90fec72ed954830e73f5d4995cc79193 (crypto: aesni - add generic
gcm(aes))

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/arch/x86/crypto

See 38d9deecab77b9eb38cb8bb5dfa43237c6710188
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/x86/crypto?id=38d9deecab77b9eb38cb8bb5dfa43237c6710188

metze


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170907/dddc78db/signature.sig>


More information about the samba-technical mailing list