[PATCH] GUID index for LDB

Stefan Metzmacher metze at samba.org
Wed Sep 6 10:44:06 UTC 2017

Hi Andrew,

>>> I'll e-mail Tridge/Douglas/Catalyst for permission on a re-licence to
>>> LGPLv3 the binary search macros next week.
>>> I know it is a massive patch set, but some feedback would be helpful.
>>> http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/GUID-index-6
> This has been a success, and I have now got some performance numbers.
> See the attached graph, with test times normalized to 1.  It shows that
>  some tasks are better (much better) and that the rest is pretty much
> un-affected.  (We have found that the noise on these measurements is
> about 5%). 

So there's no performance loss of 5% for searches?
As we're now doing one more hop from the index (now via the objectGUID)
to the dn.

Is it expected that only some workloads are faster?

Do these numbers already include the BINARY_SEARCH patches?

> This series also passes a full make test.  It also showed some flapping
> tests, so I plan to chase those down and I look forward to a positive
> review!

I guess you'll resort the commits so that the version bump happens
at the end just before the final patch that activates it in Samba?

Can you also run an autobuild without the activation in Samba,
so that we're sure we don't insert regressions for possible backports?

I'm planing to have a closer look during the next two weeks.
As this is a huge patchset that immediately results in a new
ldb release, we should take our time for this (as it won't make it
to 4.7.0) without rushing this into master.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170906/9d1c48cb/signature.sig>

More information about the samba-technical mailing list