[PATCH] libsmbclient APIs to set configuration file and Logging callback function

[Puran Chand]

Updated patch file.

Changes include
1. Removed copyright notices
2. Changed DEBUG(..) to DBG_* for logging

On Wed, Aug 16, 2017 at 5:41 PM, Puran Chand <puran157 at gmail.com> wrote:

> Added patch file,
>
> Github PR link https://github.com/samba-team/samba/pull/99
>
> On Mon, Aug 7, 2017 at 7:29 PM, Jim McDonough <jmcd at samba.org> wrote:
>
>> On 08/07/2017 06:53 AM, Puran Chand via samba-technical wrote:
>> > Hi Jim,
>> >
>> > I have sent DCO to contributing at samba.org from corporate email and each
>> > commit is also signed with corporate email.
>> >
>> >  I believe with these in place, the code can have Company copyright as
>> per
>> > Readme.contributing from github.com (
>> > https://github.com/samba-team/samba/blob/master/README.contributing)
>> >
>> > Please let me know if I am missing something here and I will take it up
>> > with right folks in the company.
>> No, you're right, so I retract my statement.  Sorry for the confusion.
>>
>> Jim
>> >
>> > I appreciate all the help.
>> >
>> > Thanks.
>> >
>> > Regards
>> >
>> > Puran Chand
>> >
>> >
>> >
>> > On 07-Aug-2017 4:00 PM, "Jim McDonough" <jmcd at samba.org> wrote:
>> >
>> > Hi,
>> > On 08/06/2017 09:45 PM, Puran Chand via samba-technical wrote:
>> >> This PR has libsmbclient APIs to set configruation file and logging
>> >> callback function which allows the libsmbclient user to capture logs.
>> >>
>> >> https://github.com/samba-team/samba/pull/95
>> >>
>> >> Review is appreciated.
>> > This is a non-technical review.  The above PR contains a corporate
>> > copyright, which is explicitly disallowed by Samba policy.  I do realize
>> > it can be difficult to get personal copyright in a large company, so I'm
>> > sorry to ask you to find out how to do that.
>> >
>> > We are more than happy to give credit in the code.  This can be done by
>> > maintaining the corporate email address, as it is in
>> source3/utils/net.c:
>> >
>> >   Copyright (C) 2001 Steve French  (sfrench at us.ibm.com)
>> >   Copyright (C) 2001 Jim McDonough (jmcd at us.ibm.com)
>> >
>> > We can also include a direct comment about the company contributing the
>> > patch, just not a copyright.
>> >
>> > Thanks,
>> > Jim
>> >
>>
>>
>
>
> --
>
> *RegardsPuran Chand*
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-libsmbclient-APIs-for-setting-configuration-fi.patch
Type: text/x-patch
Size: 13415 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170905/2fb2331b/0001-Added-libsmbclient-APIs-for-setting-configuration-fi.bin>