[PATCH] Use Intel AES instruction set if it exists.

Jeremy Allison jra at samba.org
Fri Sep 1 19:12:08 UTC 2017

On Fri, Sep 01, 2017 at 10:05:18AM -0700, Jeremy Allison via samba-technical wrote:
> OK, let's chat. In the meantime, parsing Metze's cryptic words
> of wisdom... :-)
> Isn't this:
> https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=3759eb23b38c
> *exactly* what we're both talking about ?

Indeed it was...

So as Metze already essentially *did* the libnettle work (just didn't
mention it :-) here is a version that uses libnettle for the 4 AES
functions (I added Metze's 'Signed-off-by:' as well as mine as it's
99% his work):


which (if libnettle has been compiled correctly) should use the Intel
AESNI instructions - giving the same speed benefits as the direct patch.

I'm getting Justin @ Netgear to test, so I'm not proposing this for
inclusion until I get the results - just wanted to report back sooner
rather than later (I got a bit snotty asking for resource and schedules
'cos I was pissed over people looking a gift horse in the mouth - sorry
about that). Seems I was looking Metze's gift horse in the mouth myself
(although in my defense I didn't know about it :-) :-).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lib-crypto-Add-the-ability-to-call-AES-implementatio.patch
Type: text/x-diff
Size: 4063 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20170901/9473cdcb/0001-lib-crypto-Add-the-ability-to-call-AES-implementatio.diff>

More information about the samba-technical mailing list