[PATCHES] GPO support for the AD DC itself

David Mulder dmulder at suse.com
Tue Oct 31 20:39:27 UTC 2017


This fixes a couple issues:
The crash caused by the self pointer.
A crash caused by the gpo list having NULL elements (forgot to increment i).
Need to ignore the Local Policy.

See attached.

On 10/31/2017 01:32 PM, Andrew Bartlett wrote:
> On Tue, 2017-10-31 at 13:27 -0600, David Mulder wrote:
>> So, the gpo pointer is in self, but pytalloc_get_type() is unable to
>> retrieve it.
>> If I grab the pointer manually like so:
>> struct GROUP_POLICY_OBJECT *gpo_ptr = _pytalloc_get_ptr(self);
>> Then gpo_ptr is valid and I'm able to get attributes from the GPO object.
>>
>> I assume this is the same you were seeing Andrew?
> Yes.  That might actually be all OK - if the pointer really is fine.  I
> might have been getting caught in knots. 
>
> Could this be a pointer into an array?  If so then we are doing the
> right thing already, using the new pytalloc stuff that holds a distinct
> memory context, and just need to use pytalloc_get_ptr() and trust that
> it is the right type.
>
> Thanks,
>
> Andrew Bartlett
>

-- 
David Mulder
SUSE Labs Software Engineer - Samba
dmulder at suse.com
SUSE Linux GmbH, GF: Felix Imend├Ârffer, Jane Smithard, Graham Norton, HRB 21284 (AG N├╝rnberg)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wip-fix-segfaults-in-pytalloc-fixes-for-libgpo-pytho.patch
Type: text/x-patch
Size: 1626 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171031/ebeaf1f5/0001-wip-fix-segfaults-in-pytalloc-fixes-for-libgpo-pytho.bin>


More information about the samba-technical mailing list