[PATCH] Add more tests for dbcheck

Andrew Bartlett abartlet at samba.org
Tue Oct 31 00:41:28 UTC 2017

On Mon, 2017-10-30 at 13:53 +0100, Stefan Metzmacher wrote:
> Am 30.10.2017 um 04:05 schrieb Andrew Bartlett via samba-technical:
> > This patch adds some more tests to our dbcheck test suite to try
> > and
> > cover some important cases and the recent 'dbcheck: Allow removal
> > of
> > one-way links to missing objects' patch is tested.
> > 
> > It also tries to make some of the errors less scary and into
> > warnings,
> > if they can happen in normal operation.
> > 
> > On this basis I will build a testsuite for Andrej Gessel's patch:
> > 
> > [PATCH] Fix: Failed to remove backlink of memberOf when deleting
> > dsdb_module_search_dn: did not find base dn
> > 
> > Please review!
> I'll try to have a look at the end of the week.
> I'll try to combine it with my dbcheck patches to fix
> the consequences of https://bugzilla.samba.org/show_bug.cgi?id=13095
> See
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
> v4-6-duplicate-links
> and
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/
> v4-7-duplicate-links

I've tried to forward-port that to master, which was a mission, but I
think I've done it.  More importantly I've improved the tests, and
found it handles one issue I couldn't get the old dbcheck to find,
which is a backlink to a deleted object.

The tests have been changed to use administrator and enterprise admins
to keep stable GUIDs, and now reliably pass.

There is still more work to do to squash this in to a for-master patch
series, and I may have totally mucked up the rebase, so please look

I wouldn't normally get into your WIP tree, but it seemed more helpful
than continuing parallel development.

Thanks for all your work here, and I hope this is useful!


Andrew Bartlett
Andrew Bartlett
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 862 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171031/b9d6b8dc/signature.sig>

More information about the samba-technical mailing list