[PATCH] Add more tests for dbcheck

Andrew Bartlett abartlet at samba.org
Mon Oct 30 16:07:20 UTC 2017

On Mon, 2017-10-30 at 13:53 +0100, Stefan Metzmacher via samba-
technical wrote:
> Am 30.10.2017 um 04:05 schrieb Andrew Bartlett via samba-technical:
> > This patch adds some more tests to our dbcheck test suite to try and
> > cover some important cases and the recent 'dbcheck: Allow removal of
> > one-way links to missing objects' patch is tested.
> > 
> > It also tries to make some of the errors less scary and into warnings,
> > if they can happen in normal operation.
> > 
> > On this basis I will build a testsuite for Andrej Gessel's patch:
> > 
> > [PATCH] Fix: Failed to remove backlink of memberOf when deleting
> > dsdb_module_search_dn: did not find base dn
> > 
> > Please review!
> I'll try to have a look at the end of the week.
> I'll try to combine it with my dbcheck patches to fix
> the consequences of https://bugzilla.samba.org/show_bug.cgi?id=13095
> See
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/v4-6-duplicate-links
> and
> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/v4-7-duplicate-links

Thanks for looking into this!  I've looked over the overall diff and it
certainly looks reasonable and shouldn't conflict too badly (except on
the expected output stuff, needing re-generation). 

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list