[PATCH] Avoid going via printf/escape during deleted DN creation

[Garming Sam]

The first patch is unrelated (and needs a test) and I'm currently 
dropping it.

Otherwise, I've reviewed and pushed the rest.


Cheers,

Garming


On 27/10/17 16:00, Andrew Bartlett wrote:
> G'Day,
>
> While trying (and failing, sadly) to find a root case for the flapping
> tests at:
>
> https://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-05-0940/samba.stderr
>
> I created the attached patches to prove to myself that there couldn't
> be an issue in the parent DN creation for deleted DNs.
>
> Having created the code, I think we should include it, as is reduces
> the printf() and escape calls and more clearly modifies the RDN as a
> single component.
>
> Please review/push!
>
> For context, in the above link this in particular is the still unsolved
> problem.  I would love it if someone else can look over the deleted DN
> and 'find parent dn' code and find the issue:
>
> getncchanges: failed to fetch DN
> <GUID=6e4d1cfa-9c32-40f2-ad5d-24500a681af7> -
> operational_search_post_process failed for attribute 'parentGUID' -
> Parent dn
>
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> CN=Deleted Objects,DC=samba,DC=example,DC=com
>
> for
>
> OU=test_ou_parent99,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> OU=getncchanges2659416_test\0ADEL:6bec890b-dcc6-4325-9fd2-fb2bda44c987,
> CN=Deleted Objects,DC=samba,DC=example,DC=com does not exist at
> ../source4/dsdb/samdb/ldb_modules/operational.c:365
>
> Thanks,
>
> Andrew Bartlett
>