[PATCH] Fix resource leaks and pointer issues
asn at samba.org
Fri Oct 27 05:14:33 UTC 2017
On Friday, 27 October 2017 01:04:42 CEST Jeremy Allison wrote:
> On Thu, Oct 26, 2017 at 01:28:42PM -0700, Jeremy Allison via samba-technical
> > On Thu, Oct 26, 2017 at 07:52:58AM +0200, Andreas Schneider via samba-
> > > On Thursday, 26 October 2017 01:08:30 CEST Jeremy Allison via
> > > samba-technical> >
> > > wrote:
> > > > On Wed, Oct 25, 2017 at 08:45:02PM +0200, Andreas Schneider wrote:
> > > > > Hi,
> > > > >
> > > > > I have several additional patches which should also be in the next
> > > > > 4.7
> > > > > release. Should I just open one bug for all of them or individual
> > > > > ones?
> > > >
> > > > I suggest just one bug - label it "fix resource leaks and pointer
> > > > issues".
> > >
> > > Done, the bug is:
> > >
> > > https://bugzilla.samba.org/show_bug.cgi?id=13101
> > >
> > > and I've added the bug url to all patches attached.
> > Just one note. The change in smbc_getUser() from char *
> > to const char * is an external library change, so we'll
> > need to update the shared library version number here.
> > We might want to leave that change out of the back-ports
> > to 4.7.x and 4.6.x to ensure no ABI change.
> There's also an issue with the 3rd patch, f needs to be
> checked for != stdout before closing.
> I pushed the last 3 patches, but you need to re-review
> these first 3 before push.
+1 and pushed to autobuild. I'm fine with not backporting the smbclient
change. The memleak is in the test so it isn't really important for a release
Thanks for the review!
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical