[PATCH] Fix double free in vfs_gluster_getwd()

Thu Oct 26 06:36:09 UTC 2017

On Thu, Oct 26, 2017 at 08:06:42AM +0200, Andreas Schneider via samba-technical wrote:
> On Thursday, 26 October 2017 06:37:39 CEST Volker Lendecke wrote:
> > On Wed, Oct 25, 2017 at 11:12:39AM -0700, Jeremy Allison via samba-technical 
> wrote:
> > > On Wed, Oct 25, 2017 at 07:46:03PM +0200, Andreas Schneider wrote:
> > > > Hi,
> > > > 
> > > > the attached patch addresses a double free in vfs_glusterfs.
> > > > 
> > > > Review and push much appreciated :-)
> > > 
> > > Ooh - good catch ! RB+ and pushed.
> > 
> > Wouldn't our pattern be a SAFE_FREE(cwd) instead of free(cwd) ?
> 
> That would be an additional patch just for master right?
> 
> See attached.

RB+.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de