[PATCHES] replmd: fix for linked attribute replacement with related tests

Andrew Bartlett abartlet at samba.org
Thu Oct 26 00:22:06 UTC 2017


On Wed, 2017-10-25 at 17:17 -0700, Jeremy Allison via samba-technical
wrote:
> On Thu, Oct 26, 2017 at 11:50:22AM +1300, Douglas Bagnall via samba-
> technical wrote:
> > As Björn found in https://bugzilla.samba.org/show_bug.cgi?id=13095,
> > the
> > linked attribute changes in 4.7 allow you to introduce duplicate
> > links
> > using MOD_REPLACE. This is not good.
> > 
> > Here we fix that and test for it.
> > 
> > As well as the fix itself, we find that some of the linked
> > attribute
> > tests had flawed logic that would have allowed other failures.
> > 
> > Please review and push!
> 
> Do you want all of the commit messages to refer to the
> bug URL ?
> 
> Currently only the first two do so. Just checking :-).

Thanks for looking.

The rest doesn't strictly need to be backported, they just improve the
health of master.

In the meantime, I've reviewed these and seen the postive ack on the
bug, so they are in autobuild. 

Thanks!

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba







More information about the samba-technical mailing list