[PATCH] The build with MIT KRB5 doesn't compile after process_prefork has been added
asn at samba.org
Tue Oct 24 05:40:28 UTC 2017
On Friday, 20 October 2017 09:00:42 CEST Andreas Schneider via samba-technical
> On Friday, 20 October 2017 02:21:41 CEST Andrew Bartlett wrote:
> > On Thu, 2017-10-19 at 21:03 +0200, Andreas Schneider wrote:
> > > On Thursday, 19 October 2017 20:57:40 CEST Andrew Bartlett wrote:
> > > > On Thu, 2017-10-19 at 11:28 -0700, Jeremy Allison via samba-
> > > > technical
> > > >
> > > >
> > > > Sorry, I think this is wrong. Sadly there are no automated tests
> > > > for
> > > > the MIT build as part of autobuild, and unless I'm reading the code
> > > > wrong, this will just make the use of the kpasswd server fail in
> > > > the
> > > > MIT case as that pointer needs to be filled (as it is elsewhere) in
> > > > instead of being set to NULL.
> > >
> > > So it needs to be:
> > >
> > > const struct model_ops *model_ops = process_model_startup("single");
> > No. It needs to be like the rest of the code, using task->model_ops.
> > The line you have there is the one Gary removed when the overstamp
> > pattern was changed.
> The attached patchset fixes this and updates the test to work correctly with
> latest fixes.
> Please review and push if possible.
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical