[PATCH] The build with MIT KRB5 doesn't compile after process_prefork has been added

Jeremy Allison jra at samba.org
Thu Oct 19 19:12:25 UTC 2017


On Fri, Oct 20, 2017 at 07:57:40AM +1300, Andrew Bartlett wrote:
> On Thu, 2017-10-19 at 11:28 -0700, Jeremy Allison via samba-technical
> wrote:
> > On Thu, Oct 19, 2017 at 05:37:41PM +0200, Andreas Schneider via samba-technical wrote:
> > > Hi,
> > > 
> > > the attached patch fixes building Samba with MIT Kerberos. The pointer for 
> > > model_ops is uninitialized.
> > > 
> > > error: ‘model_ops’ may be used uninitialized in this function [-Werror=maybe-
> > > uninitialized]
> > > 
> > > We have in the README.Coding that pointers should be *ALWAYS* initialized!!
> > > 
> > > 
> > > Please review and push if OK.
> > 
> > RB+. Obvious goodness. We should move towards
> > enabling compiler switches that force *all* auto
> > variables to be initialized.
> 
> -1
> 
> Sorry, I think this is wrong.  Sadly there are no automated tests for
> the MIT build as part of autobuild, and unless I'm reading the code
> wrong, this will just make the use of the kpasswd server fail in the
> MIT case as that pointer needs to be filled (as it is elsewhere) in
> instead of being set to NULL.

Sorry for missing that. Looked like obvious goodness as I assumed
NULL model_ops would be treated as "use default" inside stream_setup_socket().

Should have checked :-(. I'll pull the autobuild.



More information about the samba-technical mailing list