[PATCH] The build with MIT KRB5 doesn't compile after process_prefork has been added

Andrew Bartlett abartlet at samba.org
Thu Oct 19 18:57:40 UTC 2017

On Thu, 2017-10-19 at 11:28 -0700, Jeremy Allison via samba-technical
> On Thu, Oct 19, 2017 at 05:37:41PM +0200, Andreas Schneider via samba-technical wrote:
> > Hi,
> > 
> > the attached patch fixes building Samba with MIT Kerberos. The pointer for 
> > model_ops is uninitialized.
> > 
> > error: ‘model_ops’ may be used uninitialized in this function [-Werror=maybe-
> > uninitialized]
> > 
> > We have in the README.Coding that pointers should be *ALWAYS* initialized!!
> > 
> > 
> > Please review and push if OK.
> RB+. Obvious goodness. We should move towards
> enabling compiler switches that force *all* auto
> variables to be initialized.


Sorry, I think this is wrong.  Sadly there are no automated tests for
the MIT build as part of autobuild, and unless I'm reading the code
wrong, this will just make the use of the kpasswd server fail in the
MIT case as that pointer needs to be filled (as it is elsewhere) in
instead of being set to NULL.

We need the MIT KDC to be a full part of autobuild, with an appropriate
git tag tracked in Samba and built as part of our build process. 


Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list