[WIP][PATCH] Make dbcheck remove some dangling forward links

Jeremy Allison jra at samba.org
Tue Oct 17 18:36:12 UTC 2017


On Tue, Oct 17, 2017 at 12:00:27PM +0100, Rowland Penny via samba-technical wrote:
> On Tue, 17 Oct 2017 23:32:16 +1300
> Andrew Bartlett <abartlet at samba.org> wrote:
> 
> > On Tue, 2017-10-17 at 11:27 +0100, Rowland Penny wrote:
> > > On Tue, 17 Oct 2017 23:17:30 +1300
> > > Andrew Bartlett via samba-technical
> > > <samba-technical at lists.samba.org> wrote:
> > > 
> > > > It is quite plausible to remove dangling one-way links in the same
> > > > partition.  This patch needs tests added, but is a good start.
> > > > 
> > > > This may address some issues with replication in Samba 4.7 if this
> > > > dangling forward link is replicated out, and in any case will
> > > > shut up an annoying warning in dbcheck.
> > > > 
> > > > Andrew Bartlett
> > > 
> > > You have lines over 80 characters long, there is also a typo;
> > > 
> > > # misisng objects are plausible.
> > >   ^^^^^^^
> > 
> > What I'm clearly missing is some sleep, but this should address your
> > concerns :-)
> > 
> > Thanks!
> > 
> > Andrew Bartlett
> > 
> 
> Looks good to me now ;-)
> 
> Anybody else ?

You don't need anybody else in order to push now. 2 Samba engineers
is enough :-).



More information about the samba-technical mailing list