Failing autobuilds with a segfault in winbindd

[Andrew Bartlett]

G'Day Volker,

I've noticed two recent autobuild failures showing a segfault in winbindd.  

They started only this week (I've checked back to the start of July)

https://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-12-1238/samba.stderr
https://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-13-1240/samba.stderr
https://git.samba.org/autobuild.flakey.sn-devel-144/2017-10-16-2110/samba.stderr

Giving that the failure is in operating on a netlogon pipe and the
recent changes that I reviewed for you to the winbind code, 
I wondered if you would might be able to look into this to see if you
can work out what is going wrong?

>From the backtrace I'm wondering if it might be due to this or other
patches in this series:

> From d7e31d9f4d9ce7395e458ac341dd83ac06255a20 Mon Sep 17 00:00:00
> 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Mon, 18 Sep 2017 16:19:12 -0700
> Subject: winbindd: Use rpccli_connect_netlogon
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Is it possible that cm_connect_netlogon_transport() returns without
setting the conn->netlogon_pipe?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba