Failing test "samba3.blackbox.give_owner.grant full rights(fileserver)"
asn at samba.org
Fri Oct 13 13:20:59 UTC 2017
On Friday, 13 October 2017 15:11:14 CEST Ralph Böhme wrote:
> ...moving from samba-team to samba-technical...
> On Thu, Oct 12, 2017 at 07:13:26PM +0000, Jeremy Allison wrote:
> > RB+. I feel bad about the original tests, but they looked
> > perfectly fine to me !
> found it! Looks like you, me and every other team member whos username's
> first character wasn't a valid escape sequence was lucky and autobuild kept
> working for him.
> Everyone else like asn or vlendec not so much: /bin/sh on sn-devel-144 is
> dash which has a XSI compliant echo builtin. That means echo will always
> interpret escape sequences in strings, eg
> $ /bin/sh -c 'echo -n "\a" | hexdump -C'
> 00000000 07 |.|
> There's no way to prevent the echo command from doing this.
> In the script test_give_owner.sh echo was used to print an ACE which will
> contain a DOMAIN\USER substring. If the first character of USER is a valid
> escape sequence, the resulting string was interpreted as an escape sequence:
> $ /bin/sh -c 'echo "FILESERVER\asn"'
> The only portable way to print a string without interpreting embedded escape
> sequences seems to be using printf:
> $ /bin/sh -c 'printf "%s\n" "FILESERVER\asn"'
> Attached patch fixes the problem. Please review & push if ok.
Pushed to autobuild as my user name is an escape sequence ;)
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical