[PATCH] samba.registry Python 3 compatible and Python 2.6 fixes
asn at samba.org
Thu Oct 12 13:04:58 UTC 2017
On Thursday, 12 October 2017 11:30:28 CEST Lumir Balhar via samba-technical
> I ported another Python module, samba.registry, to Python 3 compatible
> form (patch #1) and I improved its test coverage (patch #2).
> Everything went well with Python 2.7 and 3.6 but then I found some
> issues during testing the ported module with Python 2.6.6 in VM with
> fresh CentOS 6 installation.
> The second two patches contain fixes for Python 2.6.
> The first problem I found is in lib/pam_wrapper/python/pypamtest.c where
> function PyErr_NewExceptionWithDoc is used, but this function is
> available only in Python 2.7 and higher. This bug was probably hidden
> because pam_wrapper can be installed as a distribution package. Fixed
> with #if/#else in patch 3.
Please also create a patch against:
> The second one is in testsuite/unittests/rpc_test_dummy_module.c where I
> get an error about undefined kill() function and SIGKILL constant. I
> don't know where this bug comes from, but including signal.h header file
> fixes it. Fix attached as patch 4.
Second team member needed for review.
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical