[PATCH] vfs_retention: add this module to make a share read only with a special time period.

Li, Dan lidan at cn.fujitsu.com
Wed Oct 11 06:07:10 UTC 2017


Hi, Volker

> I guess the right way to solve this would be to make getdate a subsystem
> or library on its own.
I dealed with this issue and updated the patch.
Pls check them...
Thank you!

Regards, 
Li Dan

> -----Original Message-----
> From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE]
> Sent: Tuesday, October 10, 2017 8:12 PM
> To: Li, Dan/李 丹 <lidan at cn.fujitsu.com>
> Cc: samba-technical at lists.samba.org
> Subject: Re: [PATCH] vfs_retention: add this module to make a share read
> only with a special time period.
> 
> On Tue, Oct 10, 2017 at 11:46:06AM +0000, Li, Dan wrote:
> > Hi, Volker
> >
> > Thanks for your comments!
> >
> > > Can you take a look at README.Coding in the Samba source directory?
> > > There's a lot of formatting issues with the code.
> > OK. I deal with the format issues, please check the attachments.
> > Should I squash all the 3 patches together?
> 
> Maybe. At least the first and third one belong together.
> 
> > > Then in your second patch: This should not be necessary. What fails
> exactly?
> > It failed when build the samba-static task. Pls check details from the
> following link:
> > https://travis-ci.org/samba-team/samba/jobs/264593495
> 
> I guess the right way to solve this would be to make getdate a subsystem
> or library on its own.
> 
> Volker
> 
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9 AG Göttingen, HRB 2816, GF:
> Dr. Johannes Loxen http://www.sernet.de, mailto:kontakt at sernet.de
> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vfs_retention-add-this-module-to-make-a-share-read-o.patch
Type: application/octet-stream
Size: 9742 bytes
Desc: 0001-vfs_retention-add-this-module-to-make-a-share-read-o.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171011/769701c3/0001-vfs_retention-add-this-module-to-make-a-share-read-o.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-modify-autobuild-TASK-samba-static-failed.patch
Type: application/octet-stream
Size: 2024 bytes
Desc: 0002-modify-autobuild-TASK-samba-static-failed.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171011/769701c3/0002-modify-autobuild-TASK-samba-static-failed.obj>


More information about the samba-technical mailing list