[PATCH] Patch for bug 13052
slow at samba.org
Tue Oct 10 12:57:30 UTC 2017
On Tue, Oct 10, 2017 at 12:44:56PM +0000, Volker Lendecke wrote:
> On Tue, Oct 10, 2017 at 12:45:47PM +0200, Ralph Böhme wrote:
> > Hi,
> > On Mon, Oct 09, 2017 at 04:24:33PM +0000, Ralph Böhme via samba-technical wrote:
> > > Please review&push if happy. The patchset just survived a private autobuild and
> > > was reported by a customer to fix the problem.
> > Volker suggested an additional check for the sid type returned from lookupnames,
> > updated patchset attached. With this we catch misconfigurations like:
> > idmap config Administrator : backend = rid
> > idmap config Administrator : range = 400000 - 499999
> > and log:
> > wb_xids2sids_init_dom_maps_lookupname_done: SID
> > S-1-5-21-1302242140-3407493554-1668119891-500 for idmap domain name
> > 'administrator' not a domain SID
> > While at it I factored out wb_xids2sids_init_dom_maps_lookupname_next() (smaller
> > diff!) in the first commit. Can you please re-review the first commit. The other
> > patches are unmodfied besides the minor changes for the long line and the
> > missing space.
> RB+. Can you push? Thanks!
More information about the samba-technical