[PATCH] vfs_retention: add this module to make a share read only with a special time period.

[Li, Dan]

Hi, Volker

Thanks for your comments!

> Can you take a look at README.Coding in the Samba source directory?
> There's a lot of formatting issues with the code.
OK. I deal with the format issues, please check the attachments.
Should I squash all the 3 patches together?

> Then in the manpage you mention
> 
> > The original Samba software and related utilities were created by Li
> > Dan.
> 
> I'd say this is not entriely true :-)
I am sorry for this replace miss when created this page... 

> Then in your second patch: This should not be necessary. What fails exactly?
It failed when build the samba-static task. Pls check details from the following link:
https://travis-ci.org/samba-team/samba/jobs/264593495

Regards, 

Li Dan

> -----Original Message-----
> From: Volker Lendecke [mailto:Volker.Lendecke at SerNet.DE]
> Sent: Tuesday, October 10, 2017 5:43 PM
> To: Li, Dan/李 丹 <lidan at cn.fujitsu.com>
> Cc: samba-technical at lists.samba.org
> Subject: Re: [PATCH] vfs_retention: add this module to make a share read
> only with a special time period.
> 
> On Tue, Oct 10, 2017 at 01:24:05AM +0000, Li, Dan via samba-technical wrote:
> > I create a pull request for the previous discussion about a new module
> > to implement the worm feature with a special time period.
> >
> > Please review and maybe push it...
> > Thanks very much!
> 
> Looks interesting, thanks!
> 
> A few comments:
> 
> Can you take a look at README.Coding in the Samba source directory?
> There's a lot of formatting issues with the code.
> 
> Then in the manpage you mention
> 
> > The original Samba software and related utilities were created by Li
> > Dan.
> 
> I'd say this is not entriely true :-)
> 
> Then in your second patch: This should not be necessary. What fails exactly?
> 
> Thanks, Volker
> 
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9 AG Göttingen, HRB 2816, GF:
> Dr. Johannes Loxen http://www.sernet.de, mailto:kontakt at sernet.de
> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vfs_retention-add-this-module-to-make-a-share-read-o.patch
Type: application/octet-stream
Size: 9736 bytes
Desc: 0001-vfs_retention-add-this-module-to-make-a-share-read-o.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171010/b1cd63dd/0001-vfs_retention-add-this-module-to-make-a-share-read-o.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-modify-autobuild-TASK-samba-static-failed.patch
Type: application/octet-stream
Size: 1738 bytes
Desc: 0002-modify-autobuild-TASK-samba-static-failed.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171010/b1cd63dd/0002-modify-autobuild-TASK-samba-static-failed.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-vfs_retention-modify-format-and-careless-miss.patch
Type: application/octet-stream
Size: 5349 bytes
Desc: 0003-vfs_retention-modify-format-and-careless-miss.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171010/b1cd63dd/0003-vfs_retention-modify-format-and-careless-miss.obj>