[PATCH] vfs_retention: add this module to make a share read only with a special time period.

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Oct 10 09:42:37 UTC 2017

On Tue, Oct 10, 2017 at 01:24:05AM +0000, Li, Dan via samba-technical wrote:
> I create a pull request for the previous discussion about a new
> module to implement the worm feature with a special time period.
> Please review and maybe push it... 
> Thanks very much!

Looks interesting, thanks!

A few comments:

Can you take a look at README.Coding in the Samba source directory?
There's a lot of formatting issues with the code.

Then in the manpage you mention

> The original Samba software and related utilities
> were created by Li Dan.

I'd say this is not entriely true :-)

Then in your second patch: This should not be necessary. What fails

Thanks, Volker

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list