[PATCH] s3: spoolss: Fix GUID string format on GetPrinter info

[Samuel Cabrero]

Hi Jeremy,

checks added.

Cheers.

On Fri, 2017-10-06 at 09:59 -0700, Jeremy Allison via samba-technical
wrote:
> On Fri, Oct 06, 2017 at 11:09:51AM +0200, David Disseldorp via samba-
> technical wrote:
> > On Fri, 06 Oct 2017 10:04:44 +0200, Samuel Cabrero wrote:
> > 
> > > Subject: [PATCH] s3: spoolss: Extend publish_toggle test to check
> > > returned
> > >  GUID string format
> > > 
> > > Extend the rpc.spoolss.printer.addprinter.publish_toggle test to
> > > check the format of the returned GUID string in GetPrinter info
> > > level 7 structure.
> > > 
> > > Bug: https://bugzilla.samba.org/show_bug.cgi?id=12993
> > > 
> > > Signed-off-by: Samuel Cabrero <scabrero at suse.de>
> > 
> > Looks good, thanks for adding this...
> > Reviewed-by: David Disseldorp <ddiss at samba.org>
> > 
> > @Jeremy: please push if you're okay with this.
> 
> Can you add missing return NULL from allocation
> checks in:
> 
> +               /* Build reference GUID string */
> +               ref_guid = GUID_string2(tctx, &guid);
> +               ref_guid = talloc_strdup_upper(tctx, ref_guid);
> 
> please ?
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-spoolss-Extend-publish_toggle-test-to-check-retur.patch
Type: text/x-patch
Size: 1658 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171009/bc269abf/0001-s3-spoolss-Extend-publish_toggle-test-to-check-retur.bin>