[PATCH] s3: spoolss: Fix GUID string format on GetPrinter info

Jeremy Allison jra at samba.org
Fri Oct 6 16:59:41 UTC 2017


On Fri, Oct 06, 2017 at 11:09:51AM +0200, David Disseldorp via samba-technical wrote:
> On Fri, 06 Oct 2017 10:04:44 +0200, Samuel Cabrero wrote:
> 
> > Subject: [PATCH] s3: spoolss: Extend publish_toggle test to check returned
> >  GUID string format
> > 
> > Extend the rpc.spoolss.printer.addprinter.publish_toggle test to
> > check the format of the returned GUID string in GetPrinter info
> > level 7 structure.
> > 
> > Bug: https://bugzilla.samba.org/show_bug.cgi?id=12993
> > 
> > Signed-off-by: Samuel Cabrero <scabrero at suse.de>
> 
> Looks good, thanks for adding this...
> Reviewed-by: David Disseldorp <ddiss at samba.org>
> 
> @Jeremy: please push if you're okay with this.

Can you add missing return NULL from allocation
checks in:

+               /* Build reference GUID string */
+               ref_guid = GUID_string2(tctx, &guid);
+               ref_guid = talloc_strdup_upper(tctx, ref_guid);

please ?



More information about the samba-technical mailing list