[PATCH] s3: spoolss: Fix GUID string format on GetPrinter info

[Samuel Cabrero]

Thanks David.

I extended the rpc.spoolss.printer.addprinter.publish_toggle test to
verify the format.

Cheers

On Wed, 2017-10-04 at 15:45 +0200, David Disseldorp via samba-technical 
wrote:
> Hi Samuel,
> 
> Your fix looks good, though it'd be nice to have a corresponding unit
> test....
> 
> On Fri, 22 Sep 2017 15:40:33 +0200, Samuel Cabrero via samba-
> technical wrote:
> 
> > From 41590038643649f50f4a46dee427b9790e3b6c70 Mon Sep 17 00:00:00
> > 2001
> > From: Samuel Cabrero <scabrero at suse.de>
> > Date: Thu, 21 Sep 2017 09:53:35 +0200
> > Subject: [PATCH] s3: spoolss: Fix GUID string format on GetPrinter
> > info
> > 
> > Fix regression introduced by commit a4157e7c5d75 which removed the
> > braces
> > around the printer GUID in the printer info level 7 structure.
> > 
> > MS-RPRN section 2.2 says this protocol uses curly-braced GUIDs so
> > printers
> > are deleted from the directory by the domain controller's pruning
> > service.
> > 
> 
> Please add a "Bug" tag here, i.e.
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=12993
> 
> > Signed-off-by: Samuel Cabrero <scabrero at suse.de>
> 
> Reviewed-by: David Disseldorp <ddiss at samba.org>
> 
> Cheers, David
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-spoolss-Extend-publish_toggle-test-to-check-retur.patch
Type: text/x-patch
Size: 1548 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20171006/d954aa01/0001-s3-spoolss-Extend-publish_toggle-test-to-check-retur.bin>