[PATCH] Avoid using CTDB_BROADCAST_ALL (bug 13056)
martin at meltin.net
Thu Oct 5 03:19:48 UTC 2017
On Tue, 3 Oct 2017 16:52:40 +1100, Amitay Isaacs via samba-technical
<samba-technical at lists.samba.org> wrote:
> On Fri, Sep 29, 2017 at 12:45 PM, Amitay Isaacs <amitay at gmail.com> wrote:
> > On Thu, Sep 28, 2017 at 9:17 PM, Volker Lendecke <
> > Volker.Lendecke at sernet.de> wrote:
> >> On Thu, Sep 28, 2017 at 03:19:28PM +1000, Amitay Isaacs via
> >> samba-technical wrote:
> >> Pushed, thanks!uu
> >> Volker
> > Turns out that the fix is not as trivial as I thought earlier.
> > Sorry for the trouble.
> > Just replacing all BROADCAST_ALL with BROADCAST_CONNECTED
> > introduces all sorts of race conditions during ctdb startup. Some of the
> > messages (e.g. election) have to be sent using BROADCAST_ALL.
> > I need to fix the logic for handling BROADCAST_ALL to not queue the
> > packets for dead nodes.
> Here are the updated patches.
> - Replace BROADCAST_ALL with BROADCAST_CONNECTED for
> database controls
> - Do not queue packet if the queue fd is invalid
> BROADCAST_ALL is still used in following two cases to avoid
> the race conditions during ctdb startup.
> - Election
> - Distributing tickles
> Please review and push.
Reviewed-by: Martin Schwenke <martin at meltin.net>
peace & happiness,
More information about the samba-technical