[PATCH] s3: spoolss: Fix GUID string format on GetPrinter info

David Disseldorp ddiss at suse.de
Wed Oct 4 13:45:37 UTC 2017


Hi Samuel,

Your fix looks good, though it'd be nice to have a corresponding unit
test....

On Fri, 22 Sep 2017 15:40:33 +0200, Samuel Cabrero via samba-technical wrote:

> From 41590038643649f50f4a46dee427b9790e3b6c70 Mon Sep 17 00:00:00 2001
> From: Samuel Cabrero <scabrero at suse.de>
> Date: Thu, 21 Sep 2017 09:53:35 +0200
> Subject: [PATCH] s3: spoolss: Fix GUID string format on GetPrinter info
> 
> Fix regression introduced by commit a4157e7c5d75 which removed the braces
> around the printer GUID in the printer info level 7 structure.
> 
> MS-RPRN section 2.2 says this protocol uses curly-braced GUIDs so printers
> are deleted from the directory by the domain controller's pruning service.
>

Please add a "Bug" tag here, i.e.
Bug: https://bugzilla.samba.org/show_bug.cgi?id=12993

> Signed-off-by: Samuel Cabrero <scabrero at suse.de>
Reviewed-by: David Disseldorp <ddiss at samba.org>

Cheers, David



More information about the samba-technical mailing list