Latest Time Machine Patch

Jeremy Allison jra at samba.org
Tue Oct 3 22:58:40 UTC 2017


On Tue, Oct 03, 2017 at 06:57:35PM -0400, Kevin Anderson wrote:
> Hi Jeremy,
> 
> >
> > Yes, these look good to me. Just one request - did you check this
> > under valgrind to ensure it's clean ? If so then RB+ from me.
> >
> 
> I've never run valgrind before so this was the first time attempting to do so.
> 
> I ran valgrind --leak-check=yes <smbd> both with the Avahi patch and
> without it (including starting a backup). The output for "definitely
> lost" remained the same at 2 bytes in 1 block. Should I compare other
> numbers as well?
> Kevin Anderson

Nope, sounds good - thanks for checking ! Can I get a second
Team reivewer ?



More information about the samba-technical mailing list