Latest Time Machine Patch

Kevin Anderson andersonkw2 at gmail.com
Tue Oct 3 22:57:35 UTC 2017


Hi Jeremy,

>
> Yes, these look good to me. Just one request - did you check this
> under valgrind to ensure it's clean ? If so then RB+ from me.
>

I've never run valgrind before so this was the first time attempting to do so.

I ran valgrind --leak-check=yes <smbd> both with the Avahi patch and
without it (including starting a backup). The output for "definitely
lost" remained the same at 2 bytes in 1 block. Should I compare other
numbers as well?

Thanks,
Kevin Anderson



More information about the samba-technical mailing list