[PATCH] Fix bug #13121 - Non-smbd processes using kernel oplocks can hang smbd

Ralph Böhme slow at samba.org
Wed Nov 29 22:53:31 UTC 2017


On Wed, Nov 29, 2017 at 02:13:34PM -0800, Jeremy Allison via samba-technical wrote:
> On Thu, Nov 30, 2017 at 11:05:39AM +1300, Andrew Bartlett wrote:
> > On Thu, 2017-11-30 at 06:23 +1300, Andrew Bartlett wrote:
> > > On Wed, 2017-11-29 at 08:43 -0800, Jeremy Allison wrote:
> > > > 
> > > > Thanks for persevering with this. I'm OK with you
> > > > marking it flakey now you can reproduce locally.
> > > 
> > > Good.
> > 
> > I've done the fixes required for the test, and I'll push it shortly.  
> > 
> > This is a 'real' flapping test, it also flaps on sn-devel if you run
> > the loop for long enough.
> 
> Thanks a lot ! I'm very puzzled by the error 10 though - it
> means a missing RT signal. I'll try and get some time to
> investigate with a standalone program.

if you need an additional pair of eyes, let me know. I've been carefully going
through the test looking for race conditions causing signal loss or similar, no
luck so far, test seems correct. I was specifically worried about the while loop
around tevent_loop_once, but with tevent there shouldn't be a race condition
between signal delivery and waiting for signal. *scratches head*

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/



More information about the samba-technical mailing list