[PATCH] Fix bug #13121 - Non-smbd processes using kernel oplocks can hang smbd

[Andrew Bartlett]

On Thu, 2017-11-30 at 06:23 +1300, Andrew Bartlett wrote:
> On Wed, 2017-11-29 at 08:43 -0800, Jeremy Allison wrote:
> > 
> > Thanks for persevering with this. I'm OK with you
> > marking it flakey now you can reproduce locally.
> 
> Good.

I've done the fixes required for the test, and I'll push it shortly.  

This is a 'real' flapping test, it also flaps on sn-devel if you run
the loop for long enough.

test: samba3.smb2.kernel-oplocks.kernel_oplocks8(nt4_dc)
time: 2017-11-29 07:20:01.142343Z
Bad child exit code 10
time: 2017-11-29 07:20:06.181519Z
error: samba3.smb2.kernel-oplocks.kernel_oplocks8(nt4_dc) [
Exception: Exception: Unknown error/failure. Missing torture_fail() or torture_assert_*() call?


]
time: 2017-11-29 07:20:06.000000Z
progress: pop
command: /home/abartlet/samba-1/bin/smbtorture  $LOADLIST --configfile=$SMB_CONF_PATH --option='fss:sequence timeout=1' --maximum-runtime=$SELFTEST_MAXTIME --basedir=$SELFTEST_TMPDIR --format=subunit --option=torture:progress=no --option=torture:sharedelay=100000 --option=torture:writetimeupdatedelay=500000 --target=samba3 //$SERVER/kernel_oplocks -U$USERNAME%$PASSWORD --option=torture:localdir=$SELFTEST_PREFIX/nt4_dc/share smb2.kernel-oplocks 2>&1  | /home/abartlet/samba-1/selftest/filter-subunit --fail-on-empty --prefix="samba3.smb2.kernel-oplocks." --suffix="(nt4_dc)"
expanded command: /home/abartlet/samba-1/bin/smbtorture  $LOADLIST --configfile=/home/abartlet/samba-1/st/client/client.conf --option='fss:sequence timeout=1' --maximum-runtime=1200 --basedir=/home/abartlet/samba-1/st/tmp --format=subunit --option=torture:progress=no --option=torture:sharedelay=100000 --option=torture:writetimeupdatedelay=500000 --target=samba3 //LOCALNT4DC2/kernel_oplocks -Uabartlet%localntdc2pass --option=torture:localdir=/home/abartlet/samba-1/st/nt4_dc/share smb2.kernel-oplocks 2>&1  | /home/abartlet/samba-1/selftest/filter-subunit --fail-on-empty --prefix="samba3.smb2.kernel-oplocks." --suffix="(nt4_dc)"
testsuite-error: samba3.smb2.kernel-oplocks(nt4_dc) [
Exit code was 1

 errors[1]
]
testsuite: samba3.smb2.kernel-oplocks(nt4_dc)
progress: push
time: 2017-11-29 07:20:06.000000Z
smbtorture 4.8.0pre1-DEVELOPERBUILD
Using seed 1511936406
time: 2017-11-29 07:20:06.257347Z
progress: 8
test: samba3.smb2.kernel-oplocks.kernel_oplocks1(nt4_dc)
time: 2017-11-29 07:20:06.257932Z
Acking to none [0x00] in oplock handler
WARNING!: Open caused oplock break

time: 2017-11-29 07:20:06.378665Z
successful: samba3.smb2.kernel-oplocks.kernel_oplocks1(nt4_dc)
test: samba3.smb2.kernel-oplocks.kernel_oplocks2(nt4_dc)
time: 2017-11-29 07:20:06.378684Z
time: 2017-11-29 07:20:06.513124Z


Thanks,

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba