[PATCH] vfs_fruit: conversion of FinderInfo from AppleDouble files

Ralph Böhme slow at samba.org
Wed Nov 29 14:42:15 UTC 2017


On Tue, Nov 28, 2017 at 07:34:43PM -0800, Jeremy Allison wrote:
> On Fri, Nov 24, 2017 at 04:53:36PM +0100, Ralph Böhme wrote:
> > On Tue, Nov 21, 2017 at 08:05:39AM +0100, Ralph Böhme wrote:
> > > On Mon, Nov 20, 2017 at 03:18:26PM -0800, Jeremy Allison wrote:
> > > > UNEXPECTED(failure): samba3.vfs.fruit metadata_stream.readdir_attr with names with illegal ntfs characters(nt4_dc)
> > > > REASON: Exception: Exception: ../source4/torture/vfs/fruit.c:3990: d[i].id_both_directory_info.name.s was ._test\uf022aapl, expected test\uf022aapl: bad name
> > > > envlog: SMBD LOG of: LOCALNT4DC2
> > > > fruit_streaminfo_meta_stream: Removing invalid AFPINFO_STREAM size [3] from [filtest_invalid_afpinfo]
> > > > 
> > > > Can you check this out ?
> > > 
> > > ah, the test depends on the order the filesystem returns entries in readdir and
> > > it passed on my box:
> > > 
> > > [slow at kazak scratch]$ make -j test TESTS="vfs.fruit" >/dev/null 2>&1 && echo success
> > > success
> > > 
> > > This the fixup I squashed into the patch "selftest: add "fruit:veto_appledouble
> > > = no" to fruit shares":
> > 
> > ping. :)
> 
> LGTM. RB+. Pushed !

Thanks!

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/



More information about the samba-technical mailing list