[PR PATCH] [Updated] Added libsmbclient APIs for setting configuration file

Puran Chand puran157 at gmail.com
Wed Nov 29 09:18:59 UTC 2017


Separated this in 2 separate patches and closed this.
https://github.com/samba-team/samba/pull/113
https://github.com/samba-team/samba/pull/112

- Puran

On Wed, Nov 29, 2017 at 1:17 PM, Puran Chand <puran157 at gmail.com> wrote:

> The second patch exposes an API which can be used to set logging callback
> function.
> Any code which is using the library as shared object can route the logs
> from library to its own log file for later analysis.
>
> On Wed, Nov 29, 2017 at 1:04 PM, Puran Chand <puran157 at gmail.com> wrote:
>
>> The PR was raised long back and that time the ABI file was at 0.2.4
>> version. But recently there was a conflict with master since ABI file was
>> updated to 3.0.0.
>>
>> I will work on making it 2 separate patches.
>>
>> Thanks
>>
>> On Tue, Nov 28, 2017 at 5:29 PM, Volker Lendecke <
>> Volker.Lendecke at sernet.de> wrote:
>>
>>> On Mon, Nov 27, 2017 at 12:40:23PM +0530, Puran Chand via
>>> samba-technical wrote:
>>> > Review appreciated
>>>
>>> Can you turn that into two patches, one for each topic?
>>>
>>> Also, I don't understand the second patch? Why did you not name the
>>> ABI file correct in the first patch?
>>>
>>> Volker
>>>
>>> --
>>> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
>>> phone: +49-551-370000-0, fax: +49-551-370000-9
>>> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
>>> http://www.sernet.de, mailto:kontakt at sernet.de
>>>
>>
>>
>


More information about the samba-technical mailing list