Fix typo and add missing vfs_zfsacl manpage

Timur I. Bakeyev timur at freebsd.org
Wed Nov 29 05:53:22 UTC 2017


On Tue, Nov 28, 2017 at 9:16 PM, Uri Simchoni <uri at samba.org> wrote:

> On 11/28/2017 11:00 AM, Volker Lendecke via samba-technical wrote:
> > On Mon, Nov 27, 2017 at 02:20:19PM +0100, Timur I. Bakeyev via
> samba-technical wrote:
> >> Can one of the developers review this fixes, please?
> >
> > I would have avoided reordering docs-xml/wscript, but you for sure
> > have your good reasons for this, and it does not destroy anything.
> >
> > RB+.
> >
> > Volker
> >
>
> RB+
>
> If you want this back-ported (because both the build omission and the
> phrasing can be considered as bugs), please:
> 1. open a bug in bugzilla
> 2. split the patch into 3 commits:
> a. Fixing the manpage
> b. Fixing the build
> c. sort (only for master)
>

Apparently I had a bug opened 4 months ago :) So:

https://bugzilla.samba.org/show_bug.cgi?id=12934

I've reworked patch b, so that vfs_zfacl manpage is added only if
corresponding module is enabled.


> I don't insist because it's almost or entirely FreeBSD-specific, and you
> folks seem to have your own methods of delivering backports.
>

That's part of the effort to offload local patches to upstream, as we are
getting too many of them and the could be useful for others.


> Will push tomorrow either way.
>

Thanks!

With regards,
Timur.


More information about the samba-technical mailing list