[PATCH] Cache lookupname/sid in gencache

[Ralph Böhme]

On Tue, Nov 28, 2017 at 12:52:49PM +0100, Volker Lendecke wrote:
> On Mon, Nov 27, 2017 at 11:56:43PM +0100, Ralph Böhme wrote:
> >
> >         ok = gencache_set_data_blob(
> >                 keybuf, (DATA_BLOB) { .data = (uint8_t *)val,
> >                                       .length = talloc_get_size(val) },
> >                 timeout);
> > 
> > I personally find this somewhat overloaded and would prefer having
> > argument-to-a-function initialisation as a seperate statement.
> > 
> > Does it make any difference in the generated code? What do others think?
> 
> It's highly unlikely that it makes a difference in generated code. We
> could also use data_blob_const() here or add a separate variable. I
> don't really care, but this to me is pretty dense and to the point.

too dense for my simple mind. :) So if you don't mind I'll add a helper variable
and push with that change.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/