[PATCH] Cache lookupname/sid in gencache

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 28 11:52:49 UTC 2017

On Mon, Nov 27, 2017 at 11:56:43PM +0100, Ralph Böhme wrote:
>         ok = gencache_set_data_blob(
>                 keybuf, (DATA_BLOB) { .data = (uint8_t *)val,
>                                       .length = talloc_get_size(val) },
>                 timeout);
> I personally find this somewhat overloaded and would prefer having
> argument-to-a-function initialisation as a seperate statement.
> Does it make any difference in the generated code? What do others think?

It's highly unlikely that it makes a difference in generated code. We
could also use data_blob_const() here or add a separate variable. I
don't really care, but this to me is pretty dense and to the point.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list