[PATCHES] s3-sysacls - modify SMB_ACL_PERMSET_T to be a mode_t (possible HPUX fix)

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 28 10:35:15 UTC 2017


On Tue, Nov 28, 2017 at 07:39:43AM +0200, Uri Simchoni via samba-technical wrote:
> Hi,
> 
> This patch set fixes clang picky-developer errors on FreeBSD around
> POSIX acls. It possibly also fixes an hpux issue reported in
> https://bugzilla.samba.org/show_bug.cgi?id=11490#c4

Would

--- a/source3/include/smb_acls.h
+++ b/source3/include/smb_acls.h
@@ -27,8 +27,8 @@ struct files_struct;
 struct smb_filename;

 typedef int                    SMB_ACL_TYPE_T;
-typedef mode_t                 *SMB_ACL_PERMSET_T;
-typedef mode_t                 SMB_ACL_PERM_T;
+typedef uint32_t                       *SMB_ACL_PERMSET_T;
+typedef uint32_t                       SMB_ACL_PERM_T;

 typedef enum smb_acl_tag_t SMB_ACL_TAG_T;
 typedef struct smb_acl_t *SMB_ACL_T;

possibly also solve the problem? It's not that I particularly like the
posix acl API, but it's there...

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list