[PATCH] Cache lookupname/sid in gencache

Ralph Böhme slow at samba.org
Mon Nov 27 22:56:43 UTC 2017

On Tue, Nov 21, 2017 at 09:07:03AM +0100, Volker Lendecke via samba-technical wrote:
> winbindd_cache.tdb is tightly coupled with a specific domain. For
> lookupname and lookupsid this is not right, we can ask "our" DC for
> names in any trusted domain. This patchset moves the cache for
> lookupsid and lookupname into gencache.
> Review appreciated!

nice!, and generally reviewed-by-me, but one thing that somewhat irritates me
enough so I'd like to raise it is the struct initializer in a function call
argument, ie

        ok = gencache_set_data_blob(
                keybuf, (DATA_BLOB) { .data = (uint8_t *)val,
                                      .length = talloc_get_size(val) },

I personally find this somewhat overloaded and would prefer having
argument-to-a-function initialisation as a seperate statement.

Does it make any difference in the generated code? What do others think?


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/

More information about the samba-technical mailing list