AW: AW: [PATCH] Fix: Failed to remove backlink of memberOf when deleting dsdb_module_search_dn: did not find base dn
Andrej Gessel
Andrej.Gessel at janztec.com
Mon Nov 27 10:02:45 UTC 2017
Hello Andrew,
I'm following your thread with metze and I'm happy, that it is going into master.
Thank you.
Andrej
-----Ursprüngliche Nachricht-----
Von: Andrew Bartlett [mailto:abartlet at samba.org]
Gesendet: Donnerstag, 23. November 2017 23:20
An: Andrej Gessel <Andrej.Gessel at janztec.com>; samba-technical at lists.samba.org
Betreff: Re: AW: [PATCH] Fix: Failed to remove backlink of memberOf when deleting dsdb_module_search_dn: did not find base dn
On Fri, 2017-11-24 at 11:11 +1300, Andrew Bartlett wrote:
> On Thu, 2017-11-02 at 11:10 +0000, Andrej Gessel wrote:
> > Hello Andrew,
> >
> > I rebased my patch, corrected spelling error and add Sign-Off-By
> > line.
> >
> > Additionally I have sent this bug to bugzilla-maintenance at samba.org, because I do not have an Samba bugzilla account.
> >
> > Thanks
> >
> > Andrej
>
> Thanks. Metze and I are working on getting this into master shortly,
> and then a backport will follow.
>
> Sorry this has taken so long.
>
> Andrew Bartlett
BTW, when it lands it will have this change in it:
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index 28758ab..597e49c 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -3793,7 +3793,7 @@ static int replmd_delete_remove_link(struct ldb_module *module,
msg->dn, attrs,
DSDB_FLAG_NEXT_MODULE |
DSDB_SEARCH_SHOW_EXTENDED_DN |
- DSDB_SEARCH_SHOW_DELETED,
+ DSDB_SEARCH_SHOW_RECYCLED,
parent);
This is just making us work with a possible future where we might have recycled objects.
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=c226a591762
596be6276a4b975fa501f49b36fb3
--
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
https://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list